NEXT-39991 - Fix registration url and create correct proof #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsaliu
force-pushed
the
next-39991/fix-registration-url-and-create-correct-proof
branch
from
2afbbf9 to
13b78e0
Compare
nsaliu
force-pushed
the
next-39991/fix-registration-url-and-create-correct-proof
branch
from
13b78e0 to
a4cf5f7
Compare
shyim
approved these changes
Dec 13, 2024
SimonVorgers
approved these changes
Dec 13, 2024
|
Please, do not merge yet |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=============================================
+ Coverage 99.64% 100.00% +0.35%
- Complexity 501 630 +129
=============================================
Files 77 96 +19
Lines 1114 1487 +373
=============================================
+ Hits 1110 1487 +377
+ Misses 4 0 -4 ☔ View full report in Codecov by Sentry. |
…ct proof if the URL should be sanitized
nsaliu
force-pushed
the
next-39991/fix-registration-url-and-create-correct-proof
branch
from
80290cb to
2bfb874
Compare
shyim
deleted the
next-39991/fix-registration-url-and-create-correct-proof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will solve the problem when a Shop tries to register (creation or update) with a non-sanitized URL and creates the wrong
proof.The proof must be created with the Shop URL coming from the request and not from the sanitized one.
With the Shop URL sanitized, I'm referring to this merged PR: #26